When I said that the PSA test has become controversial, here's what I meant;
Some organizations no longer recommend routine screening.
The reason is that the PSA test will detect small tumors that many men have, but never grow and never cause them problems. Treating for these positive results (and for false positives which is another problem), can cause harm from side effects to men who would not have had any problem if they did nothing.
Some studies have also shown that men who get annual PSA tests don't have any benefit from the testing.
If you want to read more about it:
Prostate-Specific Antigen (PSA) Test - National Cancer Institute
With all that said, I still get it done annually, but I keep in mind that if I get a positive result one day, the best action may still be to do nothing.